Update generation to include header and link handler #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramich
force-pushed
the
genupdate
branch
3 times, most recently
from
099db9b to
6bbee75
Compare
This also pulls in cobra markdown gen and fixes a bug where an extra line was being added to the end of the md files causing pre-commit to fail in ci and update the files locally
akasprzok
reviewed
Sep 20, 2023
Comment on lines
+71
to
+72
| // Currently cobra has a bug where there is an extra line added to the end of the md file when | ||
| // the DisableAutoGenTag = true and this causes pre-commit to have to edit the file after generation |
There was a problem hiding this comment.
You could also exclude the generated docs from end-of-file-fixer step in pre-commit.
There was a problem hiding this comment.
I considered that but the file still has an extra line which may or may not cause issues later, so I up-streamed the fix and when/if it gets merged I will move back to upstream.
xpositivityx
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
###### Auto generated by spf13/cobra on 19-Sep-2023which will cause problems with diffs laterPull in cobra markdown gen and fixes a bug where
an extra line was being added to the end of the md files
causing pre-commit to fail in ci and update the files locally
spf13/cobra#2029